fix(batch-exports): use 1MB payload limit for http batch exports #24433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
force-pushed
the
brett/http-export-size
branch
from
8ddcb3b to
33b3164
Compare
bretthoerner
changed the title
oliverb123
approved these changes
Aug 19, 2024
|
We shouldn't do (or need) this since we are bumping the limit capture side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are getting HTTP 413 from Capture when trying to migrate a user.
[Zendesk Ticket]
NOTE: Ugh, actually. We don't calculate the size until we write to disk. We could go over 2MB (because of the last event being >1MB) before we detect and flush... Probably should also bump Capture's max body size a bit like we did for rusty-hook:
posthog/rust/hook-api/src/handlers/app.rs
Line 29 in 8ddcb3b
Changes
Use 1MB limit, see comment in code.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Existing